search

rust-cli / confy

🛋 Zero-boilerplate configuration management in Rust
Other
896 stars 59 forks source link

Clean dependencies, fix cross compilation, fix runtime cargo-manifest bug, change from failure to std::error #25

Closed TheLostLambda closed 4 years ago

TheLostLambda commented 4 years ago

This also fixes a few typos in the examples.

Overall, this fixes #23, #24, and bumps the library to use new versions of all of it's dependencies.

It now works outside of cargo directories (binaries produced before this fix would crash at runtime if executed outside of a project directory — essentially rendering the library unusable). My solution was to just use an empty organization string, if someone has a better suggestion, please let me know, but the cargo-manifest solution from before was a lot of code that duplicated the user-provided string and broke at runtime.

This also cross-compiles to macOS and the number of dependencies pulled in by this library was cut in third.

TheLostLambda commented 4 years ago

Sorry for the messy commit, I got a bit carried away and forgot to split it up. That should be a nicer history now!

TheLostLambda commented 4 years ago

Okay, sounds good. I'm using this fork in the meantime. I'll let you know if I encounter any issues, but it's working well on macOS Catelina, Windows 10, Arch Linux, and Linux Mint so far.

Dylan-DPC-zz commented 4 years ago

Looks good to me. I don't see any red flags while going through the code so merging this