search

rust-cli / confy

🛋 Zero-boilerplate configuration management in Rust
Other
896 stars 59 forks source link

Config name #37

Closed Zykino closed 3 years ago

Zykino commented 3 years ago

This is based on top of #36. So t should be merged after (or in place ?). I wanted to do 1PR per issue resolved. If needed I can reorder the code to merge in the other order.

amomchilov commented 3 years ago

This PR made a breaking change, by changing the arity of the load function. It broke when I tried to run cargo install --git https://github.com/reujab/silver. I'm new to the Rust ecosystem, is there a way to workaround this, which doesn't involve waiting on a new release of silver?

https://github.com/reujab/silver/blob/master/src/main.rs#L17

Dylan-DPC-zz commented 3 years ago

@amomchilov ah yeah depending on the master branch directly isnt a good idea and any breaking change can result in breaking changes being emitted downstream. The latest change (of depending on 0.4) is the right move here. We will be releasing this as a new backwards incompatible version (0.5) instead of (0.4.1) so no more changes will be required.