rust-cli / env_logger

A logging implementation for `log` which is configured via an environment variable.
https://docs.rs/env_logger
Apache License 2.0
803 stars 125 forks source link

Fix #208 (Remove pipe for BufferWriter and implement handeling in Writer) #211

Closed TilCreator closed 2 years ago

TilCreator commented 3 years ago

Fixes #208

A test would also be nice, so that it hopefully doesn't break again unnoticed. ^^

mainrs commented 3 years ago

I'll write a test today and merge.

TilCreator commented 3 years ago

Sry for the force push, but at lest the linter fixes are cleaner now.

jplatte commented 3 years ago

Ping @mainrs.

TilCreator commented 3 years ago

Ping @mainrs

jplatte commented 2 years ago

I don't like the extra unreachable!()s at all. I'm pretty sure I've understood the problem though and will fix it shortly.