search

rust-cli / env_logger

A logging implementation for `log` which is configured via an environment variable.
https://docs.rs/env_logger
Apache License 2.0
803 stars 125 forks source link

Add `Style::set_dimmed` to support dimmed text #215

Closed LukasKalbertodt closed 2 years ago

LukasKalbertodt commented 3 years ago

Dimmed text is widely supported and has been added to termcolor in 1.1.1 in this PR: https://github.com/BurntSushi/termcolor/pull/34

Bumping the required termcolor version shouldn't be a problem, because it's only a minor bump.

mainrs commented 2 years ago

@jplatte Do you know why CI doesn't get triggered?

LukasKalbertodt commented 2 years ago

Nop, no idea. If it helps, I could "redo" the commit and force push?

mainrs commented 2 years ago

Sure, maybe it triggers it again...

mainrs commented 2 years ago

Thanks!

LukasKalbertodt commented 2 years ago

Would it be possible to release this as 0.9.1? The last release is 11 months ago and it seems like all commits from main could easily be released as a minor new version. That'd be sweet :) No stress though.

jplatte commented 2 years ago

It would be possible for sure, the only thing preventing it is time. I'd also like to mark the Target::Pipe as broken explicitly in the docs in such a release, seen as it's unclear whether / when it will be fixed (see #208).

Hard to allocate time to a project that I am not using anymore though. Do you want to join as a maintainer?

LukasKalbertodt commented 2 years ago

I totally understand as I struggle with the exact same thing myself for many projects I started. Consequently, I don't have any spare time to help out here, sorry :/