Closed SpamapS closed 10 months ago
It's still a topic where different people have different opinions. But recently an official blog post changed the recommended approach:
https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
TIL! Thanks for the pointer.
On Sun, Nov 12, 2023 at 2:33 PM mainrs @.***> wrote:
It's still a topic where different people have different opinions. But recently an official blog post changed the recommended approach:
https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
— Reply to this email directly, view it on GitHub https://github.com/rust-cli/env_logger/issues/284#issuecomment-1807264104, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS6YCFRKRR2ZO3E3JBTZTYEFFEBAVCNFSM6AAAAAA7IGQ46WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGI3DIMJQGQ . You are receiving this because you authored the thread.Message ID: @.***>
I'll close this as the public guideline now is to check them into the repository. Either way: Thanks for you contributions! :laughing:
Note that we had our Cargo.lock
before that policy change. Several of us maintainers checking in Cargo.lock
helped inform things when I advocated that policy change and then wrote that blog post.
Hi! Perhaps thinking has evolved outside the rust official docs but my understanding is Cargo.lock shouldn't ever be included in a pure library package.
https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries
It's a bit confusing to have it there.