search

rust-cli / human-panic

Panic messages for humans.
https://docs.rs/human-panic
Apache License 2.0
1.66k stars 65 forks source link

Rollup! #10

Closed killercup closed 6 years ago

killercup commented 6 years ago

Wow, there's a lot of stuff going on in this repo! This is a rollup of #6 and #9 -- and I'm pretty sure also of #8 of which #9 is pretty much a superset.

So, to summarize:

…and it finally it bumps the version to 0.3 because, even though print_msg now accepts strictly more inputs (you can still pass in a String but now also give it a Path or PathBuf of &str), the output type of handle_dump changed :(

killercup commented 6 years ago

r? @badboy @skade @yoshuawuyts

roll up premium

badboy commented 6 years ago

r+ for the Path{,Buf} stuff!

yoshuawuyts commented 6 years ago

@killercup as a side note: I don't usually tend to bump versions in a PR, but instead wait until after merge. Usually so it can be labeled & tagged in a separate commit / shows up in the commit log as standalone. Nothing to block this on though.

killercup commented 6 years ago

@yoshuawuyts ah no, that's fine, I just saw your comment in #6 about the version bump and went ahead. Let me remove that commit here. We should probably go over the docs before a release anyway

Update: @skade already delivered: #11