search

rust-cli / human-panic

Panic messages for humans.
https://docs.rs/human-panic
Apache License 2.0
1.66k stars 65 forks source link

Update to 2018 edition and prune dependencies #63

Closed johnchildren closed 4 years ago

johnchildren commented 5 years ago

Update the project to 2018 edition in both code and documentation for usage, prunes unused dependencies and removes dependency on failure, preferring the std Error trait.

There was also a misleading error message about not being able to find a temporary file directory, which would have actually have been caused by a failure to encode a filepath into UTF-8 (https://doc.rust-lang.org/src/std/path.rs.html#1848-1850). However this error should not happen anyway by just using the PathBuf directly to make the full path for the persisted file output.

Should resolve https://github.com/rust-cli/human-panic/issues/57

Choose one: is this a 🐛 bug fix, a 🙋 feature, or a 🔦 documentation change? Feature and docs

Checklist

Context

https://github.com/rust-cli/human-panic/issues/57

Semver Changes

Should take a minor bump potentially, but no changes to APIs.

johnchildren commented 5 years ago

I notice there isn't a CONTRIBUTING.md in the repo, is there one somewhere else I can look at?

johnchildren commented 5 years ago

Should note that the test failures are due to rust versions that do not support 2018 edition in the matrix - I could remove them or update to a more recent version?

Profpatsch commented 5 years ago

This repository seems unmaintained, pinging members of the rust-cli organization: @matthiasbeyer @codesections @Dylan-DPC @XAMPPRocky

codesections commented 5 years ago

Thanks for the ping. I haven't personally been involved with this repo; if this thread doesn't get a reply soon, I'll raise the issue of this repo's status in our next meeting.

Dylan-DPC-zz commented 5 years ago

@Profpatsch this isn't unmaintained, it's just that we were focussing on the other repos for a while.

So, since we are migrating to 2018 edition, we need to update the minimum rust version in the CI. Currently the build is (expectedly) failing on 1.25 and 1.29 because those versions don't support 2018 edition. So you will have to modify it. I would prefer to bump it all the way to 1.36.0 (stable - 2)

johnchildren commented 4 years ago

Thank you, have updated to 1.36.0 as suggested! Tests are now passing!