Closed curiousleo closed 4 years ago
PTAL
PTAL
pinging rust-cli WG members @codesections @Dylan-DPC @matthiasbeyer @XAMPPRocky
Our users cannot submit bug reports because of this bug, please merge and do point release, or we have to drop this package.
@matthiasbeyer I am not a member of @rust-cli
.
Oh,... why were you picked as reviewer by github then? I cannot merge, unfortunately.
I submitted a review, so github shows me in the list of reviewers.
I also don't have the correct permissions to merge this PR. It looks like @spacekookie would be able to, based on commit history.
Looks good to me. Merging it. Thanks @matthiasbeyer and special mention to @bjorn3 for showing up in the elite list of reviewers :wink:
Can I ask for a version bump nonetheless? https://github.com/rust-cli/human-panic/issues/65
🐛 Set
cause
, whether we're on nightly or not.Previously there were two cases with two sub-cases:
cause
cause
to "Unknown"expl
string as "Cause:That seems oddly complicated. This PR changes that to:
cause
cause
to "Unknown"Checklist
Context
Vaguely related to https://github.com/rust-cli/human-panic/issues/55.
Semver Changes
This changes the format of the message users see. I think it's a bugfix, but if changing what users see is considered a breaking change, then this is a breaking change.