rust-cli / human-panic

Panic messages for humans.
https://docs.rs/human-panic
Apache License 2.0
1.66k stars 65 forks source link

v1.0.2 breaks wasm-pack v0.9.1 because of #45 #71

Closed l4AgXc closed 4 years ago

l4AgXc commented 4 years ago

Choose one: 🐛 bug report

Since the release of v1.0.2 yesterday (#65), wasm-pack no longer installs. It's because of #45, which added a field to the Metadata struct.

$ cargo install wasm-pack
...
   Compiling wasm-pack v0.9.1
error[E0063]: missing field `repository` in initializer of `human_panic::Metadata`
   --> $HOME/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-pack-0.9.1/src/main.rs:105:16
    |
105 |     let meta = human_panic::Metadata {
    |                ^^^^^^^^^^^^^^^^^^^^^ missing `repository`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0063`.
error: failed to compile `wasm-pack v0.9.1`, intermediate artifacts can be found at `/tmp/cargo-install8pgGsr`

Caused by:
  could not compile `wasm-pack`.

To learn more, run the command again with --verbose.

https://github.com/rustwasm/wasm-pack/issues/818 is the corresponding wasm-pack issue.

45 is an incompatible change and really should have occasioned a major version increment.

Your Environment

$ cargo --version
cargo 1.42.0 (86334295e 2020-01-31)
spacekookie commented 4 years ago

Hey there!

Yes you're right, I've reverted the change, yanked 1.0.2 and am releasing 1.0.3 without #45 merged.

Sorry for that!