search

rust-cli / human-panic

Panic messages for humans.
https://docs.rs/human-panic
Apache License 2.0
1.66k stars 65 forks source link

Use os_info instead of os_type #73

Closed stanislav-tkach closed 3 years ago

stanislav-tkach commented 4 years ago

It is a bit controversial, because I'm the maintainer of the os_info crate, but it can detect Windows, so cfg!(windows) is no longer needed. Additionally, this crate can obtain the Windows version and support more platforms.

Checklist

Context

N/A

Semver Changes

Not sure.

The format of the operating_system field of the Report has changed, but I'm not sure if it is considered a part of the API.

spacekookie commented 3 years ago

Hey, thank you for this PR! Sorry it took so long to get back to. 2020 and all that. You know :sweat_smile: