rust-cli / rexpect

.github/workflows/ci.yml
https://docs.rs/rexpect
MIT License
328 stars 56 forks source link

fix typo in error message #100

Closed phaer closed 1 year ago

phaer commented 1 year ago

The error message in PtyReplSessions Drop impl implies that the subprocess is "bash", which isn't necessarily true and might confuse users.

phaer commented 1 year ago

Hm...not sure if this test failure is related to my current PR? I can try to install that rust version to try and reproduce if needed.

petreeftime commented 1 year ago

The gitlint check fails.

1: CC1 Body does not contain a 'Signed-off-by' line

This can be fixed by signing the commit with git commit --amend -s

phaer commented 1 year ago

Thanks, I meant the failing rust test on rust 1.60, but you are right I hadn't signed as well. Let's see if it works now. Signed my other PR as well ;)

petreeftime commented 1 year ago

bors merge

bors[bot] commented 1 year ago

Build succeeded: