rust-cli / roff-rs

ROFF (man page format) generation library
docs.rs/roff
Apache License 2.0
59 stars 11 forks source link

feat! rewrite to be for ROFF, not manual pages #15

Closed larswirzenius closed 2 years ago

larswirzenius commented 2 years ago

While looking at generating manual pages from clap:App (see, for example, https://github.com/clap-rs/clap/pull/3174), I reviewed the roff crate. I found several things that I think could be improved:

This commit introduces a complete rewrite to address my concerns. I'm afraid I could not come up with a reasonable sequence of small changes to get where I want the crate to be. The changes are radical, and break backwards compatibility, so the version number will need to be bumped.

A summary of the changes:

epage commented 2 years ago

feat! rewrite to be for ROFF, not manual pages

FYI the lint commit failed because there is a missing : after the !. As the failure says, I can take care of it in the end of you don't feel like it.

epage commented 2 years ago

Going to go ahead and merge.

Going to do a quick PR after this to fix some things up but just wanting to unblock progress on clap_man

sondr3 commented 2 years ago

I'll close my own PR here then, thanks for helping out @larswirzenius :smile:

epage commented 2 years ago

https://github.com/rust-cli/roff-rs/pull/16

epage commented 2 years ago

roff 0.2 has been released.