A slightly better approach to add weak symbols to the build for musl 1.2.4

rust-cross / cargo-zigbuild

Compile Cargo project with zig as linker

MIT License

1.43k stars 51 forks source link

Closed haohaolee closed 11 months ago

haohaolee commented 11 months ago

Add rust version check since rust 1.72 fixes the weak symbol issues for musl
Use a linker script to add missing symbols during linking for zig >= 0.11 and rust < 1.72 (it should be better than using rust-lld since we can use the old logic to adjust parameters passed to zig )

messense commented 11 months ago

Hi, I've invited you to join rust-cross organization to co-maintain cargo-zigbuild in recognition of your contributions, thanks!

haohaolee commented 11 months ago

Thanks for inviting me.