Closed reubenmiller closed 11 months ago
Thanks!
I don't think we need to add constants because usually they're just a
#define
in C, you can't refer to it in Rust so it's not needed here.
Thanks for the assist. I leaned towards adding add #defines
since it was generally easier to remove than add.
It'd be great if you can confirm that this actually fixes #179 for your project, thanks!
It'd be great if you can confirm that this actually fixes #179 for your project, thanks!
Just added a comment that our project builds on this PR. https://github.com/rust-cross/cargo-zigbuild/issues/179#issuecomment-1713192771
Extending the musl weak symbol mappings to resolve https://github.com/rust-cross/cargo-zigbuild/issues/179.
The symbol list was generated via scrapping the header files from the musl source code at (http://git.musl-libc.org/cgit/musl/)
fyi: I'm fairly new at the compiler stuff, so if this PR went to far than I'm happy to adjust as directed.