search

rust-cv / cv

Rust CV mono-repo. Contains pure-Rust dependencies which attempt to encapsulate the capability of OpenCV, OpenMVG, and vSLAM frameworks in a cohesive set of APIs.
831 stars 64 forks source link

Progress towards fixing akaze orientation #66

Closed stephanemagnenat closed 1 year ago

stephanemagnenat commented 1 year ago

This contains my further changes for correcting Akaze's orientation, without the dump functions (the version with the dump is here).

I kept the corrections in different commits.

I used imageproc for running the Gaussian filters, but I retained the kernel from Akaze because it is properly normalized. I did not remove the now-unused functions horizontal_filter and vertical_filter. Should I remove them?

@vadixidav it is unclear for me whether you expected me to push directly in the branch on this repository, so I did this PR.

vadixidav commented 1 year ago

@stephanemagnenat Please feel free to push directly to the upstream branch. You should now have permissions to do so.

stephanemagnenat commented 1 year ago

@vadixidav pushing to upstream failed: ERROR: Permission to rust-cv/cv.git denied to stephanemagnenat.

vadixidav commented 1 year ago

@stephanemagnenat I just updated the default permissions for members, and I believe that you should be able to now push to the branch. Please add your changes to that branch. If you need to force push that is fine too, just preserve the changes. Also, please test against akaze using the changes I added.