search

rust-dc / fish-manpage-completions

Straight port of fish-shell's Python manpage completion script to Rust
19 stars 8 forks source link

feat: add basic progress bar #111

Closed pickfire closed 2 years ago

pickfire commented 3 years ago

Add progress bar with indicatif while parallelizing stuff. It does not show what file it is processing so we may need to have a custom painter. Fix #50, #82

Debug ~20s Release ~600ms

output-opt

A simple implementation for this does not show custom progress, but if we want we need to do some custom painting, it can be done later.

While working on this I found logging missing some stuff.

scooter-dangle commented 2 years ago

@pickfire, hey!

Were you thinking of doing anything more on this branch or should I just cleanup some of the commented-out code and merge it in?

I knew we could parallelize, but jeez, rayon gives us a massive kick in the pants. If I run the current fish_update_completions locally, it takes about 16 seconds. For the same inputs, the release build on this PR comes in at just under 400ms.

pickfire commented 2 years ago

No, I forgot what was I thinking for the next step so need to check back again.