search

rust-dc / fish-manpage-completions

Straight port of fish-shell's Python manpage completion script to Rust
19 stars 8 forks source link

Add deroff fn letter #46

Closed pmatseykanets closed 5 years ago

pmatseykanets commented 5 years ago

If str_at implementation will be fixed this function should work as expected. Right now it breaks on Unicode characters i.e. (ï).

Original implementation

def letter(self, idx):
    ch = self.str_at(idx)
    return ch.isalpha() or ch == '_' # underscore is used in C identifiers
pmatseykanets commented 5 years ago

@scooter-dangle @PureW please take a look. Thanks!

scooter-dangle commented 5 years ago

Kinda embarrassing to realize this now, but it doesn't look like letter is actually used anywhere. Can modify PR to just remove the commented-out Python source. 🤦‍♂

scooter-dangle commented 5 years ago

Subsumed by #54