search

rust-dev-tools / rls-analysis

Core functionality for handling rustc's save-analysis data
39 stars 26 forks source link

Why is Def.sig commented out? #135

Open jendrikw opened 6 years ago

jendrikw commented 6 years ago

It is commented out since 9cf1eeb2ddf0d49a75a0911b28468cab911ba271, but there is no reason given. It would be very useful to have the signature information.

Also, the structs Signature and SigElement are unused.

nrc commented 6 years ago

It should probably be removed along with the structs.

The story is that the signature info emitted by the compiler (https://github.com/nrc/rls-data/blob/master/src/lib.rs#L308) has changed significantly and I removed (well, commented out) support for the old signature information with the intention of adding back support for the new info. However, I haven't yet got around to that.