Add embedded-nal-async - Githubissues

rust-embedded-community / embedded-nal

An Embedded Network Abstraction Layer

Apache License 2.0

177 stars 25 forks source link

Add embedded-nal-async #66

Closed lulf closed 2 years ago

lulf commented 2 years ago

Add embedded-nal-async crate containing async traits requiring Generic Associated Types (GAT) feature on nightly for now.
Add async traits for TCP, UDP and DNS.
Add embedded-nal-async build to CI

Example implementations:

https://github.com/drogue-iot/drogue-device/blob/embedded-nal-traits/device/src/drivers/wifi/esp8266/mod.rs#L419 https://github.com/drogue-iot/drogue-device/blob/embedded-nal-traits/device/src/drivers/tcp/std.rs#L28 https://github.com/drogue-iot/drogue-device/blob/embedded-nal-traits/device/src/drivers/dns.rs#L34

Fixes #65

lulf commented 2 years ago

@ryan-summers Thanks for the review! Should be addresses, not sure about the repo/homepage links as the crate is not in the 'root' of the repo and pointing to a specific directory would require referring to the 'main' branch in the cargo file.

lulf commented 2 years ago

Thank you both for the quick responses. Let me know if you want me to squash the changes.

ryan-summers commented 2 years ago

@eldruin Are you okay with merging as-is? All of my concerns have been addressed

chrysn commented 2 years ago

Thanks, that's a very welcome addition.

I've given it a test drive by updating the std-embedded-nal crate to have UDP implemented also for async. All smooth sailing, provided one accepts the known GAT and TAIT caveats.