rust-embedded-community / embedded-nal

An Embedded Network Abstraction Layer
Apache License 2.0
177 stars 25 forks source link

Bump no-std-net dependency to 0.6, MSRV to 1.53 #76

Closed chrysn closed 1 year ago

chrysn commented 1 year ago

The no-std-net version currently used (0.5) failed to parse SocketAddr strings "[fe80::1]%2", which works correctly in the 0.6 version.

Incrementing the version is this easy change (nothing inside current embedded-nal appears to depend on the precise version), but it is an API breaking change in the crates here because types are re-exported and their API changed. (For example, Ipv6Addr::unspecified() became Ipv6Addr::UNSPECIFIED). Given that these crates have not yet had non-breaking updates, that's probably not a big deal.

chrysn commented 1 year ago

CI told me that this necessitates an MSRV increase to 1.53, which is now enacted in a second commit.

chrysn commented 1 year ago

Thanks for the quick review, that allows me to rebase #73 and saves me workarounds.