async: Do not use heapless on public API.

rust-embedded-community / embedded-nal

An Embedded Network Abstraction Layer

Apache License 2.0

177 stars 25 forks source link

Closed Dirbaio closed 10 months ago

Dirbaio commented 10 months ago

It's better to not use heapless on the public API.

It can get major bumps from time to time (for example v0.8 was just relased), and upgrading it is a breaking change of embedded-nal-async, which we should try to avoid.
It allows users to use any version of heapless, or something else entirely.

ryan-summers commented 10 months ago

Would you be willing to copy these over to the non-async version as well? I agree with the sentiment here, and we have the same problem over there.

Dirbaio commented 10 months ago

@ryan-summers done

also note I've separated the MSRV bump to #94, review that first.