search

rust-embedded-community / menu

Command-line menu system for embedded Rust platforms.
Apache License 2.0
51 stars 11 forks source link

Feature gate local echo. #9

Closed badrbouslikhin closed 1 year ago

badrbouslikhin commented 1 year ago

Hello!

I'd like to propose adding a feature gate that disables local echo.

To implement this, I've added a new no-echo feature flag to the Cargo.toml file and wrapped the relevant code in an #[cfg(not(feature = "no-echo"))] block. I've also added code to write the whole command after a carriage-return is a sent. This is wrapped in an #[cfg(feature = "no-echo")].

I believe this feature will be useful for users who want to disable local echo in certain cases (when using menu with RTT transport for ex.). Please let me know if you have any questions or concerns.

Thank you!

badrbouslikhin commented 1 year ago

It took me a long time to come back to this. It's done!

badrbouslikhin commented 1 year ago

Done! I've also added a brief doc comment.