rust-embedded-community / meta

Details about the rust-embedded-community project
12 stars 8 forks source link

Transfer SSD1306, SSD1331 and SH1106 drivers to r-e-c #28

Closed jamwaffles closed 5 months ago

jamwaffles commented 5 months ago

As per the instructions, would someone be so kind as to nominate themselves or another username so I can transfer https://github.com/jamwaffles/ssd1306, https://github.com/jamwaffles/ssd1331 and https://github.com/jamwaffles/sh1106 to r-e-c please?

eldruin commented 5 months ago

You can transfer them to me. Thank you for all your work! I have actually used the ssd1306 crate many times :)

jamwaffles commented 5 months ago

I'm glad my code has been useful :)

Heh... this is a fun edgecase:

image

image

Would it be best to delete your forks or do they have additional changes in them?

rfuest commented 5 months ago

If you like I could also help with maintaining the crates. I don't have any SSD1331 displays, but the e-g test board we designed with a SSD1306 display and a SH1106 display is always ready to test reported issues.

How about creating an org for the embedded display drivers to share the maintenance burden? Maybe @almindor would also be interested in adding the mipidsi crate to that org to have the most popular e-g display drivers in a common place? This could also facilitate code reuse between the different drivers, like what was planned with the display-driver-hal and packed-display-buffer crates.

The display-interface crate also doesn't seem to be very actively maintained at the moment and could also live in that org, if the owner agrees.

eldruin commented 5 months ago

Would it be best to delete your forks or do they have additional changes in them?

I had not encountered that yet either. I just submitted changes a long time ago. I have removed my forks now.

Regarding an additional org please feel free to choose as you will. I would only say that anybody is welcome to join this org and we are open to accepting more crates as well and help maintain them. At the moment we are 11 members (not all public) and 9 outside collaborators so crates probably have a good chance here. Either way, you have my encouragement.

jamwaffles commented 5 months ago

I had not encountered that yet either. I just submitted changes a long time ago. I have removed my forks now.

Thanks. I've started the transfer of those two crates.

How about creating an org for the embedded display drivers to share the maintenance burden?

Interesting idea but I no longer have a horse in this race so I'll let others decide what to do. I'm opening up possibilities by transferring these crates into r-e-c but beyond that, go wild :)

eldruin commented 5 months ago

Alright. I have completed the transfer to this org, then. @jamwaffles you are still admin for those repos and the previous collaborators are still granted their privileges. Since it is a family of crates, I added a @rust-embedded-community/embedded-graphics team as maintainer to the repos that anybody here can join. That team has publishing privileges on crates.io. @rfuest what I said still stands. Just let us know what you want to do.

almindor commented 5 months ago

If you like I could also help with maintaining the crates. I don't have any SSD1331 displays, but the e-g test board we designed with a SSD1306 display and a SH1106 display is always ready to test reported issues.

How about creating an org for the embedded display drivers to share the maintenance burden? Maybe @almindor would also be interested in adding the mipidsi crate to that org to have the most popular e-g display drivers in a common place? This could also facilitate code reuse between the different drivers, like what was planned with the display-driver-hal and packed-display-buffer crates.

The display-interface crate also doesn't seem to be very actively maintained at the moment and could also live in that org, if the owner agrees.

I'm not opposed to having a graphics org. Right now it seems it's just me in maintenance mode and @rfuest so it'd be great if we could get more people interested and widen the approval pool.

jamwaffles commented 5 months ago

These all look to be in e-g-c now so I'll close this issue. Thanks for moving them @eldruin!