search

rust-embedded-community / pc-keyboard

PS/2 Keyboard Decoder in Rust
Apache License 2.0
96 stars 28 forks source link

make everything const #19

Closed TheBotlyNoob closed 1 year ago

TheBotlyNoob commented 1 year ago

I don't think we can make it const without raising the MSRV because I'm getting on version 1.40.0

error[E0723]: trait bounds other than `Sized` on const fn parameters are unstable
   --> src\lib.rs:311:6
    |
311 | impl<T, S> Keyboard<T, S>
    |      ^
    |
    = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
    = help: add `#![feature(const_fn)]` to the crate attributes to enable

cc @thejpster

thejpster commented 1 year ago

Yes you'll need to raise the MSRV to 1.56 for this to work. I'm fine with that.

TheBotlyNoob commented 1 year ago

:+1:

thejpster commented 1 year ago

thank you!