rust-embedded-community / pc-keyboard

PS/2 Keyboard Decoder in Rust
Apache License 2.0
96 stars 28 forks source link

Process key events should pass through modifiers consistently #29

Closed jonathanpallant closed 1 year ago

jonathanpallant commented 1 year ago

If you are calling process_keyevent, some modifiers come straight out and some don't:

We should be consistent. As as people might want both a Unicode decode of the alphabet keys, but also know when e.g. Left and Right shift are pressed (e.g. to control the flippers in a pinball game) it seems to make sense to always pass through the modifiers, even if we also note their new position.