search

rust-embedded-community / rust-measurements

Metric, Imperial, and other measurement handling for Rust. Length, Temperature, Weight, and Volume
https://crates.io/crates/measurements
27 stars 10 forks source link

Created new Humidity and Density modules #27

Closed pukeko37 closed 3 years ago

pukeko37 commented 4 years ago 
* Responded to Issue #19 - added humidity module
* Created density module (required for one output from Humidity)
* Updated ReadMe to include Density and Humidity
* Added new modules into lib.rs
* [TODO: updates to CHANGELOG, etc...]
  [TODO (Possibly): Add more native units (g/m3), (kg/L), (g/mL), (t/m3), (oz/cu in), (oz/US fl oz), (lb/cu yd)... ]
drodil commented 3 years ago

@eldruin should this also be reviewed? It has been here quite a long time..

jhbruhn commented 3 years ago

How are the chances of this getting merged? I am implementing a sensor driver which would need the temperature and humidity structs and would prefer to use this library for both!

pukeko37 commented 3 years ago

Sorry about the delay. I submitted the PR over a year ago and got no response for a long time. It was supposed to be a quick PR to get changes I needed upstream, so I could use the crate in my app. I didn't even put my changes in a new feature branch. In the end, because I got no response from the maintainers, I put my changes in my own private library. So, I lost interest in helping ...

Anyway. I've responded to the maintainers. Up to them now.

eldruin commented 3 years ago

@pukeko37 could you rebase this against master? GitHub is complaining about conflicts.

pukeko37 commented 3 years ago

I just noticed, The README.md has a list of modules in it. Not updated with humidity and density.

pukeko37 commented 3 years ago

I thought I did rebase it. I've been editing in GitHub. I don't have a local dev environment.

pukeko37 commented 3 years ago

I think that's done it, but I'm not sure. Please let me know

eldruin commented 3 years ago

GitHub still shows conflicts. I'm not sure which, though.

pukeko37 commented 3 years ago

When I try to fetch upstream, my fork repository says: This branch is not behind the upstream rust-embedded-community:master.

Not sure what I need to do.

pukeko37 commented 3 years ago

This PR also says: "This branch has no conflicts with the base branch".

eldruin commented 3 years ago

Ok I was able to rebase and merge these changes manually to the current master. Thank you very much @pukeko37!