Newtype, variants and unit

rust-embedded-community / serde-json-core

`serde-json` for `no_std` programs

Apache License 2.0

161 stars 59 forks source link

Closed MabezDev closed 3 years ago

MabezDev commented 4 years ago

Adds ser/de for the following types:

unit types, i.e () & struct Test;
newtype structs, ser/de'ing the underlying value
Variants:
- The newtype_variant format, i.e Variant(u32)
- The struct_variant format, i.e Variant { x: u32, y: u16 }

MathiasKoch commented 4 years ago

+1 on this! Did a test yesterday, and it also fixes support for externally tagged enums (https://serde.rs/enum-representations.html)

Good job!

MathiasKoch commented 4 years ago

Ping @japaric

eldruin commented 3 years ago

@MathiasKoch how do you want to go about this one? Would you be able to pull these changes into a new PR and adapt them?

MathiasKoch commented 3 years ago

Sure thing, give me 5 minutes.

Will try to fix the CI clippy stuff at the same time.

MathiasKoch commented 3 years ago

@MabezDev Thank you very much for your work here!

I am closing this, as i have moved it to #42 with a rebase on master, to get this moving.