make heapless optional - Githubissues

rust-embedded-community / serde-json-core

`serde-json` for `no_std` programs

Apache License 2.0

161 stars 59 forks source link

make heapless optional #55

Closed MabezDev closed 3 years ago

MabezDev commented 3 years ago

Makes heapless an optional dep
Feature gate heapless uses throughout the code
Enable heapless feature by default for backwards compat

My rational is that I only ever use the {to,from}_slice methods in this crate, pulling in a heapless dep for no reason.

MabezDev commented 3 years ago

Done :)

MabezDev commented 3 years ago

Would it be possible to get a patch release given that this isn't a breaking change? If there is other stuff in the pipeline then I'm happy to wait :)

eldruin commented 3 years ago

Sure, I just opened #56. The next big thing would be updating to const_generics MVP and heapless 0.7.

eldruin commented 3 years ago

For the record, I have published this as part of release 0.4.0 🎉