rust-embedded-community / serde-json-core

`serde-json` for `no_std` programs
Apache License 2.0
161 stars 59 forks source link

make Serializer and Deserializer pub and usable #72

Closed jordens closed 1 year ago

jordens commented 1 year ago

This is required when using serde_json_core with code that is generic over the serde implementation, i.e. code that wants to instantiate the Serializer/Deserializer, in the way done in de::from_slice and ser::to_slice.

This also adds public getters for the Serializer.current_length and Deserializer.index members.

Two obsolete/unused impls on the Unreachable have been removed.

jordens commented 1 year ago

No. Might be dependencies. You may be using your own older Cargo.lock.

jordens commented 1 year ago

A sufficient set of dependency updates that includes the breaking change are these:

    Updating proc-macro2 v1.0.47 -> v1.0.66
    Updating quote v1.0.23 -> v1.0.32
    Updating serde v1.0.100 -> v1.0.175
    Updating serde_derive v1.0.100 -> v1.0.175
    Updating syn v1.0.109 -> v2.0.27
eldruin commented 1 year ago

All runs fine on 1.56.0. Could you update the MSRV to 1.56.0?

eldruin commented 1 year ago

Great, sorry but could you also update the MSRV in the README?

jordens commented 1 year ago

Also src/lib.rs...