rust-embedded-community / serde-json-core

`serde-json` for `no_std` programs
Apache License 2.0
161 stars 59 forks source link

add optional defmt support for error types #76

Closed avlec closed 1 year ago

avlec commented 1 year ago

add defmt as an optional dependent package

I am only able to test defmt v0.3.0 as the rest of my project is using that version the latest is at v0.3.5

closes #75

avlec commented 1 year ago

I hope I did the CI part properly if not feel free to amend that... Edit: yeah you'll have to point out where the change is actually required or do an amend

vhdirk commented 1 year ago

Is there anything here I can help with to get this merged?

ryan-summers commented 1 year ago

@vhdirk At this point, I would consider this PR abandoned. If you want to fork this current work and address my remaining comments, I'd be happy to review it as a separate PR :)

Georges760 commented 1 year ago

@vhdirk if you can't do it, i can also help, tell me

ryan-summers commented 1 year ago

It's already being continued in https://github.com/rust-embedded-community/serde-json-core/pull/77 for now :)

avlec commented 1 year ago

@vhdirk Thanks for picking up where I started with this and getting it in there!