rust-embedded-community / sh1106

SH1106 driver for use with embedded_hal and (optionally) embedded_graphics
Apache License 2.0
34 stars 36 forks source link

Fixed command bytes #23

Closed bodyweightenergy closed 3 years ago

bodyweightenergy commented 3 years ago

Changed first bytes for Command::PreChargePeriod and Command::VcomhDeselect to be what they should be in the datasheet (0xD9 and 0xDB, respectively).

This fix got the driver working properly for my hardware setup (Raspberry Pi Zero W + WaveShare SH1106 HAT). Before this fix, the display would behave differently in based on what seemed to be background cosmic radiation; sometimes it would work perfectly, sometimes it would go dark after a few seconds of displaying something.

This relates to issue https://github.com/jamwaffles/sh1106/issues/7.

jamwaffles commented 3 years ago

This has been released in 0.3.4. Please let me know if you run into any issues.

bodyweightenergy commented 3 years ago

I can verify that 0.3.4 works with my hardware. Thanks for the prompt response!

jamwaffles commented 3 years ago

Excellent :grin: