search

rust-embedded-community / sh1106

SH1106 driver for use with embedded_hal and (optionally) embedded_graphics
Apache License 2.0
34 stars 36 forks source link

The PreChargePeriod/VcomhDeselect commands are incorrect #7

Closed mvirkkunen closed 3 years ago

mvirkkunen commented 5 years ago

While fixing the addressing I went through all the other commands as well to see if they match up with the datasheet and the two commands in the title seem to be incorrect. I honestly don't know what they do, so I didn't touch them, but I can see the values don't correspond with the ones in the datasheet.

jamwaffles commented 5 years ago

Was this fixed in #6? Please close if so :+1:

mvirkkunen commented 5 years ago

Nope, it wasn't. I don't really know what those commands do, they're probably just being ignored by the controller as unknown commands, but I'm not sure. I'm pretty sure the datasheet doesn't mention them though.

jamwaffles commented 5 years ago

They can probably go then. Perhaps I shouldn't have based this crate off the SSD1306 one :sweat_smile:. PRs welcome or I'll check the datasheet cram a commit into master to remove them.

bodyweightenergy commented 3 years ago

I got you a PR that fixes this. (https://github.com/jamwaffles/sh1106/pull/23)

jamwaffles commented 3 years ago

Closed by #23