rust-embedded-community / ssd1306

SSD1306 OLED driver
Apache License 2.0
300 stars 68 forks source link

Move reset to DisplayModeTrait #126

Closed bugadani closed 4 years ago

bugadani commented 4 years ago

The functionality is common, so the implementation can be as well.

Hi! Thank you for helping out with SSD1306 development! Please:

PR description

Just a bit of cleanup. Should be backwards compatible since the trait is in the prelude. I don't think there should be a changelog entry for this one.

bugadani commented 4 years ago

Fair enough. I also marked it as breaking

bugadani commented 4 years ago

No worries, thanks for accepting my contributions :)

jamwaffles commented 4 years ago

Any time!