Closed bugadani closed 4 years ago
Closing this, basically with the same reasoning as here
While I still think this PR was a nice enough solution, this was done for performance only. If anybody needs extra performance, they are allowed to roll their own GraphicsMode
, so I believe the added complexity hurts maintainability more here.
Hi! Thank you for helping out with SSD1306 development! Please:
master
if you're not already up to dateCHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmt
on the project withcargo fmt --all
- CI will not pass without this stepPR description
The removed code from #125, based on top of #125, hence the pile of commits.