rust-embedded-community / ssd1306

SSD1306 OLED driver
Apache License 2.0
283 stars 69 forks source link

New, more consistent terminal font #137

Closed jamwaffles closed 3 years ago

jamwaffles commented 3 years ago

Hi! Thank you for helping out with SSD1306 development! Please:

PR description

This font is taken from the ATIx_550_8x8.png font image from the romfonts repo. I picked it because it looks nice, but that's subjective. It looks like this:

I don't have hardware to test with tat the moment so I might have messed up the character mappings. I'd appreciate if someone could test on a physical display and see how this looks.

I'm not including any of the special characters defined in that font. If we want to add them, I'd suggest we do that in a future PR.

Closes #135

therealprof commented 3 years ago

This font is taken from the ATIx_550_8x8.png font image from the romfonts repo.

Could there be a copyright issue?

It's certainly very retro. ;)

jamwaffles commented 3 years ago

Yeah, I did think about copyright but decided to use it anyway :grimacing:. Should we continue with the current choice anyway?

The Uzebox wiki has some alternative 8x8 fonts but a) "Some may still be under copyright" and b) I can't be bothered to turn the bitmaps into hex :(

therealprof commented 3 years ago

Have you checked out sites like: https://jared.geek.nz/2014/jan/custom-fonts-for-microcontrollers ?

jamwaffles commented 3 years ago

I haven't, thanks for the link! Any idea what the copyright is like? I'll have a look through those fonts and find something suitable.

jamwaffles commented 3 years ago

Honestly, none of them look that good. I'm ok going with the original font for now.

jamwaffles commented 3 years ago

I took some time to switch to zxpix from https://jared.geek.nz/2014/jan/custom-fonts-for-microcontrollers. It's converted from TTF to bitmap, so there were some artifacts in a few of the characters, mostly the lowercase ones. I've fixed those manually. Licensing shouldn't be an issue now.

jamwaffles commented 3 years ago

image

Looks like this now.

therealprof commented 3 years ago

Nice! 👍