rust-embedded-community / ssd1306

SSD1306 OLED driver
Apache License 2.0
283 stars 69 forks source link

Add Raspberry Pi example #160

Closed btielen closed 2 years ago

btielen commented 2 years ago

PR description

Added a simple example based on a existing example for the Raspberry Pi. Due to some strange dependencies problems, I had to switch to rust version 2021 (stabilized in rust 1.56) which automatically solved the problems. Reconfigured and improved CircleCI configuration to support multiple examples for different targets. See #48

Thanks to @PatrickLang for creating the first example.

btielen commented 2 years ago

CircleCI passing: https://app.circleci.com/pipelines/github/btielen/ssd1306?branch=add_raspberry_example

jamwaffles commented 2 years ago

Thanks for the PR! I haven't had much capacity to focus on this crate recently, but this PR gave me a kick to take a look at #133 again as well. IMO, I think the approach in #133 is better as it doesn't require an MSRV bump or Cargo hacks to make work so I'd like to go in that direction if you don't mind. This crate gets quite a lot of downloads so I think it's important to remain compatible even with older Rust versions.

btielen commented 2 years ago

No worries, your considerations make sense :)

jamwaffles commented 2 years ago

Thanks :). I'll close this PR in favour of #133.