Hi! Thank you for helping out with SSD1306 development! Please:
[x] Check that you've added documentation to any new methods
[x] Rebase from master if you're not already up to date
[x] Add or modify an example if there are changes to the public API
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
[x] Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
[x] Check that your branch is up to date with master and that CI is passing once the PR is opened
PR description
Some code doesn't rely on the display interface. This PR moves these to impl blocks that don't restrict DI to any particular trait. While this isn't immediately useful, this refactor will help in avoiding code duplication.
I've added FastNoop instead of short circuiting the current Noop command just in case someone relies on the current command's details. Backwards compatibility FTW. FastNoop is currently used to fill out Command arrays where a particular option requires less elements than the array's capacity.
Warning: some of my decisions may be controversial.
Hi! Thank you for helping out with SSD1306 development! Please:
masterif you're not already up to dateCHANGELOG.mdentry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmton the project withcargo fmt --all- CI will not pass without this stepPR description
Some code doesn't rely on the display interface. This PR moves these to impl blocks that don't restrict DI to any particular trait. While this isn't immediately useful, this refactor will help in avoiding code duplication.
I've added
FastNoopinstead of short circuiting the currentNoopcommand just in case someone relies on the current command's details. Backwards compatibility FTW.FastNoopis currently used to fill out Command arrays where a particular option requires less elements than the array's capacity.Warning: some of my decisions may be controversial.