Update to embedded-hal-1.0.0

rust-embedded-community / ssd1306

SSD1306 OLED driver

Apache License 2.0

299 stars 68 forks source link

Update to embedded-hal-1.0.0 #207

Closed irii closed 1 month ago

irii commented 8 months ago

Hi! Thank you for helping out with SSD1306 development! Please:

[x] Check that you've added documentation to any new methods
[x] Rebase from master if you're not already up to date
[x] Add or modify an example if there are changes to the public API
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
[x] Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
[ ] Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Updated to embedded-hal 1.0.0 Updated rust-version to 1.75 for display-interface package

Works on an CM4 module with I2C

jamwaffles commented 8 months ago

P.s. CI is failing. I don't have much time to look into it right now so I'd appreciate it if you can see if you can fix the issues.

irii commented 8 months ago

Thanks for the information. I will have a look by time. BR

irii commented 8 months ago

The main reason of failing is the missing embedded-hal 1.0.0 support for stm32f1xx-hal. Maybe the examples should be migrated to stm32f4xx-hal (already has 1.0.0) or disable until an implementation is available.

Sycrosity commented 5 months ago

Any progress on this? I've been using my own embedded-hal v1.0.0 fork instead, however this seems a little more polished than mine. I would be happy to migrate the CI to another platform if needed!

irii commented 5 months ago

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

Sycrosity commented 5 months ago

@Sycrosity Currently not. All examples use the stm32f1xx-hal library. This library currently has no support for embedded hal 1.0 which is the main reason for the currently paused development.

If it would help, I would happily switch the examples over to something like esp-hal, which I am quite familar with writing code for.

ne0h commented 4 months ago

Any progress so far? I would also much appreciate if this PR would be merged as it also solves my issue (https://github.com/jamwaffles/ssd1306/pull/211).

irii commented 4 months ago

Currently not because of lack of time.

A workaround would be to use https://github.com/ryankurte/embedded-hal-compat which has now offical support for embedded-hal 1.0.0

BR, Ivan

eldruin commented 1 month ago

Fixed in #213. Thank you for your work!