search

rust-embedded-community / tm4c-hal

An Embedded HAL and general chip support for the TM4C123/LM4F120. Replaces the old lm4f120 crate.
Apache License 2.0
40 stars 27 forks source link

Road to 1.0 #37

Open thejpster opened 4 years ago

thejpster commented 4 years ago

What do we need to do to put out a 1.0 release? One assumes we at least need an embedded-hal 1.0 (https://github.com/rust-embedded/embedded-hal/issues/177)

kellda commented 2 years ago

I think something that should be done on the next breaking release is using the "sealed trait" pattern for *Pin traits.

I.e. having a private trait Sealed and requiring *Pin: Sealed. This would be better than (and should be done instead of) writing "DO NOT IMPLEMENT THIS TRAIT" in the docs.

Btw, why are internal macros such as uart_hal_macro and uart_pin_macro exposed in the API ?

thejpster commented 2 years ago

Happy to see a PR.

Macros I think are shared between tm4c123 and 129 and hence exported from tm4c common.