search

rust-embedded-community / usb-device

Experimental device-side USB framework for microcontrollers in Rust.
MIT License
413 stars 77 forks source link

Changelog: add another `EndpointType` changelog to "Breaking" part #125

Closed eZioPan closed 11 months ago

eZioPan commented 11 months ago

https://github.com/rust-embedded-community/usb-device/blob/7ebb10fe5f952955b416c5b05abc84d37bf82acf/CHANGELOG.md?plain=1#L22-L23

Since EndpointType is a public enum, and some crates may use the integer form of it. After this modification user will need to call .to_bm_attributes() to access numeric form. We might add a another changelog to tell user about this.

### Breaking
+++ * Acess numeric form of `EndpointType` variants now require a `.to_bm_attributes()` ([#60](https://github.com/rust-embedded-community/usb-device/pull/60)).
eldruin commented 11 months ago

Thanks for noticing this. Could you put this into a PR?

eZioPan commented 11 months ago

please review my PR