search

rust-embedded-community / usbd-midi

MIT License
46 stars 19 forks source link

version bump and release? #9

Closed x37v closed 4 months ago

x37v commented 2 years ago

Is the code as is stable enough for a new release? I see that crates.io has usbd-midi 0.2.0 but that version doesn't have the midi read support that is in the main branch here..

btrepp commented 2 years ago

I haven't really tested the community contributions. So mileage may vary for 'stable' in a non production version.

I believe most people are using it from git.

That being said, I am happy to release a new version of it helps. The changes shouldn't really be all that incompatible.

On Fri, 6 May 2022, 01:40 Alex Norman, @.***> wrote:

Is the code as is stable enough for a new release? I see that crates.io has usbd-midi 0.2.0 but that version doesn't have the midi read support that is in the main branch here..

— Reply to this email directly, view it on GitHub https://github.com/btrepp/usbd-midi/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAGFMR4Z2K7JC4UJR4IH3VIQBY3ANCNFSM5VFY4IEQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

x37v commented 2 years ago

I'm able to use it from git too but was initially a little confused when the example on the front page didn't work with what I had installed via crates.io .. not uncommon with rust projects, nice that it is so easy.

btrepp commented 2 years ago

Ah yeah I guess some of the prs didn't update the doc.

Honestly I am not super actively developing this. It was used in a device that is completed, which I don't need new firmware for, but I am happy to maintain and help others.

In regards to the example. If you could update it a PR that would be great. From there I will publish it to crates to help any other newcomers.

On Fri, 6 May 2022, 07:35 Alex Norman, @.***> wrote:

I'm able to use it from git too but was initially a little confused when the example on the front page didn't work with what I had installed via crates.io .. not uncommon with rust projects, nice that it is so easy.

— Reply to this email directly, view it on GitHub https://github.com/btrepp/usbd-midi/issues/9#issuecomment-1119139649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAGFO6SLZLOYPUNAAWJ6LVIRLNBANCNFSM5VFY4IEQ . You are receiving this because you commented.Message ID: @.***>

x37v commented 1 year ago

Honestly I am not super actively developing this. It was used in a device that is completed, which I don't need new firmware for, but I am happy to maintain and help others.

Hey @btrepp .. I am willing/interested to take this crate over and migrate it over to https://github.com/rust-midi/

I have a PR #11 up here that integrates the shared midi type/conversion code that @mendelt and I have been collaborating on and also have a re-org/simplification staged that I believe addresses the concerns of the previous #10 draft request. If you want to take a look at #11 I'd be happy for that but if you're just wanting to hand off the project I'd fork it over to rust-midi (and ideally get crates.io access for usbd-midi eventually).

btrepp commented 1 year ago

I've had a look at #11 and am happy with it, just have a suggestion for the breaking change aspect and it's good to go.

I'm happy for it to be moved into rust-midi. It's logical to sit inside a broader ecosystem, and will make it easier to use and align the types.

I've added you as a collaborator to this repo to help facilitate this.

x37v commented 1 year ago

I've added you as a collaborator to this repo to help facilitate this.

Hey @btrepp .. I'm not 100% sure what you intended by adding me as a collaborator. I'm not able to initiate a transfer to rust-midi myself as a collaborator, but I think I can merge etc.

I could simply fork over to rust-midi and eventually you could give me the keys to crates.io .. but there is also a notion of transferring a repo over to an organization..

sourcebox commented 4 months ago

Version 0.3.0 was just released on crates.io.