Closed thejpster closed 4 years ago
Some simple improvements to be made before 1.0:
const-fn
feature, and the build.rs logic related to const fn
supportOther blockers:
Unresolved questions:
bare_metal::Peripheral
used? Does it pull its weight? Needs more documentation.bare_metal::Nr
. Would it be better to move it outside this crate? Also: Why return u8
? It should probably be renamed to something like Interrupt
, since it's not a trait for numbers.As soon as I find the markdown version of the API checklist, I’m going to create a tracking issue for that work so items can be checked off as they’re reviewed.
Found it. Will open the tracking issue when time allows. https://github.com/rust-lang/api-guidelines/blob/master/src/checklist.md
As agreed in the 2020-03-10 meeting we're taking off the Mutex
from the 1.0 blocker list. We're aiming to have the new Mutex
based on mutex-trait
implemented by the arch crates instead.
Maybe Nr
can be used as a parameter to configure vendor specific interrupt controller. However in this way Nr::nr
should not always return a u8
(there could be more than 256 interrupts). It could be necessary to provide as Nr { type Id; fn nr(&self) -> Self::Id }
(still working on it to adapt to Bumblebee's ECLIC controller)
IMO Nr
logically belongs in architecture-specific core crates like cortex-m or cortex-m-rt.
We should check what uses it, and whether the users would see any benefit of having a traits that's shared between architectures. Maybe come up with potential use cases.
(EDIT: #32 deleted it)
Ticked MSRV, as it's in the README.
Closed by #35.
Part of https://github.com/rust-embedded/wg/issues/383
Blockers:
Peripheral
be removed?Nr
trait? (it's gone)