rust-embedded / book

Documentation on how to use the Rust Programming Language to develop firmware for bare metal (microcontroller) devices
https://docs.rust-embedded.org/book/
Apache License 2.0
1.12k stars 179 forks source link

fix: Circled Image not visible on B&W E-Ink screen #339

Closed nthState closed 1 year ago

nthState commented 1 year ago

fix: Circled Image not visible on B&W E-Ink screen

Background

I've been reading this book on my Kindle, which has a black and white e-ink screen, when I came to the section about a pin header, I couldn't easily see the circled pin header.

Fix

The fix was to change the way the image was highlighted

Old (Colour) Old (Black and White)
verify verify_bw
New (Colour) New (Black and White)
verify_new verify_bw_new

Testing Steps

Acceptance Criteria

adamgreig commented 1 year ago

Thanks, this is a good improvement! I wonder if it could be even higher contrast when in colour though -- perhaps the rest of the image could be even further dimmed, or a thick border in another colour added around the highlight region?

jonathanpallant commented 1 year ago

I'd merge this as-is; it's a good enough improvement and we can always go around again later.

nthState commented 1 year ago

Apologies, I'm not a great user of graphical tools to create what you suggest/need

bors[bot] commented 1 year ago

Build succeeded: