Closed abt8601 closed 1 year ago
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
Following the discussion on #348, this PR proposes the following changes to the Interoperability section:
core::ffi
.std::os::raw
.I intentionally kept mentions of the
cty
crate and thecstr_core
crate since the next section uses the former. We may also consider updating the following section to usecore::ffi
instead of thecty
crate.This PR also introduces two additional changes.
First, it changes the descriptions regarding the implicit conversion between C and Rust types. The book says that the compiler implicitly converts between the two types, but it doesn't sound right to say that the example (reproduced below) works because of the conversion. It works simply because, on platforms where
unsigned int
is 32-bit long,c_uint
andu32
are the same type because the former is a type alias of the latter. This PR also removes theunsafe
from the example since I believe it plays no role.Second, it changes the text formatting in the type correspondence table. The types in the table now use code formatting. Also, the presentation of C pointer types is updated (e.g.
*char
→char *
).Closes #348.