search

rust-embedded / cargo-binutils

Cargo subcommands to invoke the LLVM tools shipped with the Rust toolchain
Apache License 2.0
474 stars 41 forks source link

Prevent calling `rustc_version::version_meta()` multiple times #101

Closed EFanZh closed 2 years ago

EFanZh commented 3 years ago

The custom RefError type can be removed once Rust 1.51 releases and references to errors implement Error trait: https://github.com/rust-lang/rust/pull/75180.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.