rust-embedded / cargo-binutils

Cargo subcommands to invoke the LLVM tools shipped with the Rust toolchain
Apache License 2.0
474 stars 41 forks source link

README.md: Fix objdump example #105

Closed davidlattimore closed 2 years ago

davidlattimore commented 2 years ago

objdump needs a double dash for long flags.

rust-highfive commented 2 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @reitermarkus (or someone else) soon.

Please see the contribution instructions for more information.

adamgreig commented 2 years ago

Looks like a dependency has increased its MSRV with a semver-compatible change, so our effective MSRV is now at least 1.40 due to non_exhaustive.

If anyone wants to do a separate PR to bump our MSRV (in the README and in CI) up from 1.38 to 1.40 that would be great, otherwise I'll try and get it done in a few days.

davidlattimore commented 2 years ago

Sure, I'll send a PR...

adamgreig commented 2 years ago

Thanks for the MSRV PR! Please could you rebase this one now that #106 is merged?

bors[bot] commented 2 years ago

Build succeeded: