Closed fishrockz closed 2 years ago
r? @adamgreig
(rust-highfive has picked a reviewer for you, use r? to override)
Hah, binutils swapping from one dash to two sure left a loft of legacy in its wake. Thanks for the PR.
As far as I can see, it should be a capital -O
for output target; what version of objcopy are you using that wants a lower-case -o
?
I got carried away, you are quite right that copy object is using -O
while strip now needs -o
sorry about that.
Thanks for the review.
in regard to versions
cargo strip --release -- --version
gives:
llvm-strip, compatible with GNU strip
LLVM (http://llvm.org/):
LLVM version 13.0.0-rust-1.60.0-nightly
Optimized build.
Default target: x86_64-unknown-linux-gnu
Host CPU: znver1
I installed via rustup component add llvm-tools-preview
Im not quite sure how the nightly got in there, some of the projects i use have nightly in rust-toolchain
in some of my projects but i cant remember which directory i run the rustup command.
Anther missing dash and a wrong case for a option
I found these after i had submitted #114 or i would have just added them to that one, Thanks for merging so fast @Emilgardis :D
These are supper handy tools and have already helped me a load!