Closed david-boles closed 4 years ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@rubberduck203 any thoughts on this PR?
Whoops, just noticed the clean task is formatted the same way. On the assumption that what I did is correct, I'll make another commit to change that too.
Some other notes: I tried restarting vscode as I hadn't since installing rust-lang
's rust extension and the problem persists. I got a notification pointing to the following error:
Error: The cargo task detection didn't contribute a task for the following configuration:
{
"label": "cargo clean",
"type": "cargo",
"subcommand": "clean",
"group": "build"
}
The task will be ignored.
@adamgreig I can test it sometime in the next 24 hrs.
bors.toml: not found
My VSCode install wasn't showing the default build task. Based on the other ones, this seems to have fixed it.