search

rust-embedded / cortex-m-rt

Minimal startup / runtime for Cortex-M microcontrollers
https://rust-embedded.github.io/cortex-m-rt/
Apache License 2.0
359 stars 85 forks source link

Make Vector public in interrupt example #280

Closed Tiwalun closed 4 years ago

Tiwalun commented 4 years ago

If the Vectorunion is not public, the example code leads to a compilation error because pub static __INTERRUPTS leaks the private type Vector.

rust-highfive commented 4 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jonas-schievink commented 4 years ago

Hmm, why is CI not catching this? It does build doctests.

jonas-schievink commented 4 years ago

Oh, because rustdoc puts everything in an fn main(), and pub does nothing there.

Tiwalun commented 4 years ago

I've tried adding an explicit fn main(), but that doesn't help, the test still passes without the pub.

bors[bot] commented 4 years ago

Build succeeded: