search

rust-embedded / cortex-m-rt

Minimal startup / runtime for Cortex-M microcontrollers
https://rust-embedded.github.io/cortex-m-rt/
Apache License 2.0
358 stars 85 forks source link

Minor documentation fix - add information about link.x being necessary. #321

Closed JDuchniewicz closed 3 years ago

JDuchniewicz commented 3 years ago

This baffled me so much i had to ask on matrix about it 😄. As a newcomer to embedded Rust I found it confusing.

rust-highfive commented 3 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thalesfragoso (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

adamgreig commented 3 years ago

Thanks for the PR! No problem including this clarification, but perhaps we could call it a file instead of a section to avoid confusion with the linker sections themselves.

therealprof commented 3 years ago

@JDuchniewicz Mind squashing that? Two commits for one sentence seems a bit unnecessary. 😅

JDuchniewicz commented 3 years ago

I think you can squash it when merging. I am away from computer for the weekend.

therealprof commented 3 years ago

@JDuchniewicz Individual squashing with bors is not implemented as of yet: https://forum.bors.tech/t/rfc-bors-r-squash-to-squash-commits-in-a-specific-pr/509

bors[bot] commented 3 years ago

Build succeeded:

JDuchniewicz commented 3 years ago

Oh I didn't know, thanks!